Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use source generation for INotifyPropertyChanging/Changed #679

Merged
merged 4 commits into from
Feb 19, 2023

Conversation

VMelnalksnis
Copy link
Owner

@VMelnalksnis VMelnalksnis commented Feb 12, 2023

Changes proposed in this pull request:

  • Use source generator for INotifyPropertyChanged
  • Extract remaining common properties for UpsertionViewModel
  • Refactor remaining unit view models
  • Use DI where possible for view models
  • Remove .dll, .exe and appsettings.json instead of all files on install/uninstall

@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Merging #679 (c607d28) into master (b9c8770) will increase coverage by 4.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #679      +/-   ##
==========================================
+ Coverage   69.19%   73.32%   +4.13%     
==========================================
  Files         304      212      -92     
  Lines        9216     6134    -3082     
  Branches      683      359     -324     
==========================================
- Hits         6377     4498    -1879     
+ Misses       2584     1477    -1107     
+ Partials      255      159      -96     
Impacted Files Coverage Δ
...shade.Avalonia.Core/Accounts/AccountOverviewRow.cs
...valonia.Core/Accounts/AccountUpsertionViewModel.cs
...ade.Avalonia.Core/Authentication/LoginViewModel.cs
...valonia.Core/Configuration/PreferencesViewModel.cs
....Core/Counterparties/CounterpartyMergeViewModel.cs
...de.Avalonia.Core/Counterparties/CounterpartyRow.cs
...e/Counterparties/CounterpartyUpsertionViewModel.cs
...meshade.Avalonia.Core/DesignTime/DesignTimeData.cs
...nomeshade.Avalonia.Core/Imports/ImportViewModel.cs
...ce/Gnomeshade.Avalonia.Core/MainWindowViewModel.cs
... and 82 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@VMelnalksnis VMelnalksnis marked this pull request as ready for review February 19, 2023 09:40
@VMelnalksnis VMelnalksnis merged commit c607d28 into master Feb 19, 2023
@VMelnalksnis VMelnalksnis deleted the property-changes-source-gen branch February 19, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant