Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default scheme, fix username/password login #702

Merged
merged 4 commits into from
Feb 21, 2023
Merged

Conversation

VMelnalksnis
Copy link
Owner

Could resolve #428, worked locally but will have to deploy a nightly release to confirm.

Also fixes an issue with Login page, which still used email as the username.

@VMelnalksnis VMelnalksnis added type:bug Something isn't working area:ui Relating to user interface labels Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #702 (f3bc3d5) into master (b48e70e) will decrease coverage by 0.95%.
The diff coverage is 34.81%.

@@            Coverage Diff             @@
##           master     #702      +/-   ##
==========================================
- Coverage   73.32%   72.38%   -0.95%     
==========================================
  Files         212      218       +6     
  Lines        6134     6275     +141     
  Branches      359      407      +48     
==========================================
+ Hits         4498     4542      +44     
- Misses       1477     1566      +89     
- Partials      159      167       +8     
Impacted Files Coverage Δ
...eas/Identity/Pages/Account/ExternalLogin.cshtml.cs 13.46% <0.00%> (ø)
...i/Areas/Identity/Pages/Account/LoginWith2Fa.cshtml 0.00% <0.00%> (ø)
...dentity/Pages/Account/LoginWithRecoveryCode.cshtml 0.00% <0.00%> (ø)
...pi/Areas/Identity/Pages/Account/Register.cshtml.cs 27.27% <0.00%> (ø)
...hade.WebApi/V1/Controllers/OwnershipsController.cs 68.00% <0.00%> (ø)
...reas/Identity/Pages/Account/LoginWith2Fa.cshtml.cs 28.20% <28.20%> (ø)
...tity/Pages/Account/LoginWithRecoveryCode.cshtml.cs 31.42% <31.42%> (ø)
...ebApi/Areas/Identity/Pages/Account/Login.cshtml.cs 37.14% <37.14%> (ø)
...e.WebApi/Areas/Identity/Pages/Account/Login.cshtml 70.58% <70.58%> (ø)
...omeshade.WebApi/Configuration/AuthConfiguration.cs 91.73% <75.00%> (-0.20%) ⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

This triggers the authentication pipeline again, which throws an exception. Maybe need to return problem details instead of just a status code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ui Relating to user interface type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebApi logs full of 'Failed to validate the token.' mesages
1 participant