Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HealthController instead of middleware #724

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

VMelnalksnis
Copy link
Owner

Fixes #457

@VMelnalksnis VMelnalksnis added type:bug Something isn't working area:api labels Mar 6, 2023
@VMelnalksnis VMelnalksnis changed the title Use HealthController instead of middleware (#457) Use HealthController instead of middleware Mar 6, 2023
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@192c362). Click here to learn what that means.
The diff coverage is 73.33%.

@@            Coverage Diff            @@
##             master     #724   +/-   ##
=========================================
  Coverage          ?   73.61%           
=========================================
  Files             ?      220           
  Lines             ?     6336           
  Branches          ?      415           
=========================================
  Hits              ?     4664           
  Misses            ?     1499           
  Partials          ?      173           
Impacted Files Coverage Δ
source/Gnomeshade.WebApi/Startup.cs 97.50% <ø> (ø)
...omeshade.WebApi/V1/Controllers/HealthController.cs 73.33% <73.33%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@VMelnalksnis VMelnalksnis merged commit 948aeaf into master Mar 6, 2023
@VMelnalksnis VMelnalksnis deleted the health-checks branch March 6, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Health check endpoint is not versioned or included in open api definitions
1 participant