Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve first time configuration for desktop client #735

Merged
merged 4 commits into from
Mar 14, 2023

Conversation

VMelnalksnis
Copy link
Owner

Related to #463

Changes proposed in this pull request:

  • Prompt for API base address if not set
  • Optionally ask for OIDC provider settings

@VMelnalksnis VMelnalksnis added type:bug Something isn't working type:enhancement New feature or request area:ui Relating to user interface labels Mar 14, 2023
@VMelnalksnis VMelnalksnis marked this pull request as ready for review March 14, 2023 18:00
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #735 (c1a9c4b) into master (96b2e3f) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
- Coverage   73.58%   73.46%   -0.13%     
==========================================
  Files         220      221       +1     
  Lines        6338     6347       +9     
  Branches      416      416              
==========================================
- Hits         4664     4663       -1     
- Misses       1500     1510      +10     
  Partials      174      174              
Impacted Files Coverage Δ
source/Gnomeshade.WebApi.Client/NullOidcClient.cs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@VMelnalksnis VMelnalksnis merged commit c1a9c4b into master Mar 14, 2023
@VMelnalksnis VMelnalksnis deleted the first-time-config branch March 14, 2023 18:04
@VMelnalksnis VMelnalksnis temporarily deployed to github-pages March 14, 2023 18:04 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ui Relating to user interface type:bug Something isn't working type:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant