Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor importing, move bank reference to external #738

Merged
merged 4 commits into from
Mar 19, 2023

Conversation

VMelnalksnis
Copy link
Owner

Fixes #241

Changes proposed in this pull request:

  • Move bank reference values to external reference
  • Populate both bank and external reference when importing

@VMelnalksnis VMelnalksnis added type:bug Something isn't working area:api labels Mar 18, 2023
@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Merging #738 (c6ffeeb) into master (e4bc220) will increase coverage by 1.48%.
The diff coverage is 85.64%.

@@            Coverage Diff             @@
##           master     #738      +/-   ##
==========================================
+ Coverage   73.46%   74.95%   +1.48%     
==========================================
  Files         221      225       +4     
  Lines        6347     6281      -66     
  Branches      416      380      -36     
==========================================
+ Hits         4663     4708      +45     
+ Misses       1510     1441      -69     
+ Partials      174      132      -42     
Impacted Files Coverage Δ
...ce/Gnomeshade.Data.Sqlite/Dapper/DecimalHandler.cs 50.00% <50.00%> (ø)
...eshade.WebApi/V1/Controllers/NordigenController.cs 82.89% <66.07%> (+12.68%) ⬆️
...de.WebApi/V1/Importing/TransactionImportService.cs 86.26% <86.26%> (ø)
...eshade.WebApi/V1/Controllers/Iso20022Controller.cs 91.78% <94.87%> (+15.84%) ⬆️
...meshade.Data.Sqlite/ServiceCollectionExtensions.cs 100.00% <100.00%> (ø)
...Gnomeshade.Data/Repositories/TransferRepository.cs 94.11% <100.00%> (+1.26%) ⬆️
...ource/Gnomeshade.WebApi.Client/GnomeshadeClient.cs 80.43% <100.00%> (+0.14%) ⬆️
...ource/Gnomeshade.WebApi.Client/SuccessfulImport.cs 100.00% <100.00%> (ø)
.../Importing/ImportingServiceCollectionExtensions.cs 100.00% <100.00%> (ø)
...shade.WebApi/V1/Importing/Iso20022ImportService.cs 100.00% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@VMelnalksnis VMelnalksnis marked this pull request as ready for review March 19, 2023 08:38
@VMelnalksnis VMelnalksnis merged commit c6ffeeb into master Mar 19, 2023
@VMelnalksnis VMelnalksnis deleted the bank-reference branch March 19, 2023 08:39
@VMelnalksnis VMelnalksnis temporarily deployed to github-pages March 19, 2023 08:40 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple entries can have the same reference number for different transactions
1 participant