Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importing #742

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Fix importing #742

merged 3 commits into from
Mar 22, 2023

Conversation

VMelnalksnis
Copy link
Owner

Fixes #741

Changes proposed in this pull request:

  • Fix requisition selection in Nordigen integration tests
  • Fix sign of amount for the other account besides the users' when importing from Nordigen
  • Fix issue finding an existing account by name when IBAN is not specified when importing transactions

@VMelnalksnis VMelnalksnis added type:bug Something isn't working area:api labels Mar 22, 2023
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #742 (b093b37) into master (b269df4) will increase coverage by 0.02%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##           master     #742      +/-   ##
==========================================
+ Coverage   77.01%   77.04%   +0.02%     
==========================================
  Files         225      225              
  Lines        6292     6298       +6     
==========================================
+ Hits         4846     4852       +6     
  Misses       1446     1446              
Impacted Files Coverage Δ
...de.WebApi/V1/Importing/TransactionImportService.cs 90.68% <0.00%> (ø)
...eshade.WebApi/V1/Controllers/NordigenController.cs 85.88% <90.90%> (+0.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@VMelnalksnis VMelnalksnis merged commit b093b37 into master Mar 22, 2023
@VMelnalksnis VMelnalksnis deleted the fix-importing branch March 22, 2023 20:01
@VMelnalksnis VMelnalksnis temporarily deployed to github-pages March 22, 2023 20:01 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transaction import creates duplicate account
1 participant