Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a linked product to categories #745

Merged
merged 4 commits into from
Mar 25, 2023
Merged

Add a linked product to categories #745

merged 4 commits into from
Mar 25, 2023

Conversation

VMelnalksnis
Copy link
Owner

Fixes #720

Changes proposed in this pull request:

  • Add ability to add shared database migrations to the data project instead of copying same SQL for all databases
  • Create an optional product for each category, and automatically update it's name together with the category

@VMelnalksnis VMelnalksnis added type:enhancement New feature or request area:ui Relating to user interface area:api labels Mar 25, 2023
@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Merging #745 (6790ce3) into master (7aff5c4) will increase coverage by 0.20%.
The diff coverage is 94.82%.

@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
+ Coverage   77.04%   77.24%   +0.20%     
==========================================
  Files         225      226       +1     
  Lines        6298     6342      +44     
==========================================
+ Hits         4852     4899      +47     
+ Misses       1446     1443       -3     
Impacted Files Coverage Δ
...rce/Gnomeshade.Data/Migrations/DatabaseMigrator.cs 86.66% <81.81%> (+12.47%) ⬆️
...hade.WebApi/V1/Controllers/CategoriesController.cs 91.04% <97.43%> (+7.71%) ⬆️
source/Gnomeshade.Data/Entities/CategoryEntity.cs 100.00% <100.00%> (ø)
...ade.Data/Migrations/MigrationScriptNameComparer.cs 100.00% <100.00%> (ø)
...urce/Gnomeshade.WebApi.Models/Products/Category.cs 100.00% <100.00%> (ø)
...meshade.WebApi.Models/Products/CategoryCreation.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@VMelnalksnis VMelnalksnis merged commit 6790ce3 into master Mar 25, 2023
@VMelnalksnis VMelnalksnis deleted the linked-category branch March 25, 2023 09:23
@VMelnalksnis VMelnalksnis temporarily deployed to github-pages March 25, 2023 09:24 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api area:ui Relating to user interface type:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically create a product with the same name as a category
1 participant