Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenTelemetryOptions to service collection #749

Merged
merged 2 commits into from
Mar 26, 2023
Merged

Conversation

VMelnalksnis
Copy link
Owner

Fixes #748

Currently only the default values were used, ignoring any changes made in IConfiguration. This should fix the issue, since locally I had an exporter running on the default endpoint.

This doesn't explain why the troubleshooting steps didn't work in ubuntu, though.

@VMelnalksnis VMelnalksnis added type:bug Something isn't working area:api labels Mar 26, 2023
@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Merging #749 (7d1054b) into master (f53ddf9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #749   +/-   ##
=======================================
  Coverage   74.71%   74.71%           
=======================================
  Files         324      324           
  Lines        9242     9244    +2     
=======================================
+ Hits         6905     6907    +2     
  Misses       2337     2337           
Impacted Files Coverage Δ
...ebApi/Configuration/ServiceCollectionExtensions.cs 100.00% <ø> (ø)
...bApi/Configuration/ConfigureOtlpExporterOptions.cs 100.00% <100.00%> (ø)
...de.WebApi/Configuration/OpenTelemetryExtensions.cs 97.82% <100.00%> (+0.04%) ⬆️
...bApi/Configuration/Options/OpenTelemetryOptions.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@VMelnalksnis VMelnalksnis merged commit 7d1054b into master Mar 26, 2023
@VMelnalksnis VMelnalksnis deleted the fix-otel branch March 26, 2023 07:49
@VMelnalksnis VMelnalksnis temporarily deployed to github-pages March 26, 2023 07:49 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open Telemetry exporter does not work on linux
1 participant