Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move IdentityContext tables to the default schema #791

Merged
merged 1 commit into from
May 4, 2023

Conversation

VMelnalksnis
Copy link
Owner

Turns out Microsoft.Data.Sqlite does not support schemas, even though it's possible to get functionality equivalent to schemas by using ATTACH DATABASE

Turns out Microsoft.Data.Sqlite does not support schemas, even though it's possible to get functionality equivalent to schemas by using ATTACH DATABASE
@VMelnalksnis VMelnalksnis added type:bug Something isn't working area:api labels May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #791 (2ecad3e) into master (5c344e8) will increase coverage by 0.96%.
The diff coverage is 87.75%.

@@            Coverage Diff             @@
##           master     #791      +/-   ##
==========================================
+ Coverage   74.14%   75.11%   +0.96%     
==========================================
  Files         337      341       +4     
  Lines        9589    10198     +609     
==========================================
+ Hits         7110     7660     +550     
- Misses       2479     2538      +59     
Impacted Files Coverage Δ
...grations/PostgreSQLIdentityContextModelSnapshot.cs 0.00% <0.00%> (ø)
...e/Migrations/SqliteIdentityContextModelSnapshot.cs 0.00% <0.00%> (ø)
...a.Sqlite/Migrations/20230504074721_RemoveSchema.cs 48.33% <48.33%> (ø)
...stgreSQL/Migrations/20230504074751_RemoveSchema.cs 53.73% <53.73%> (ø)
...Migrations/20230504074751_RemoveSchema.Designer.cs 100.00% <100.00%> (ø)
...shade.Data.PostgreSQL/PostgreSQLIdentityContext.cs 100.00% <100.00%> (ø)
...Migrations/20230504074721_RemoveSchema.Designer.cs 100.00% <100.00%> (ø)
...ce/Gnomeshade.Data.Sqlite/SqliteIdentityContext.cs 100.00% <100.00%> (ø)
source/Gnomeshade.Data/Identity/IdentityContext.cs 100.00% <100.00%> (ø)

@VMelnalksnis VMelnalksnis merged commit 2ecad3e into master May 4, 2023
12 checks passed
@VMelnalksnis VMelnalksnis deleted the db-schema-fix branch May 4, 2023 08:37
@VMelnalksnis VMelnalksnis temporarily deployed to github-pages May 4, 2023 08:37 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant