Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Check for references before marking entity as deleted #859

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

VMelnalksnis
Copy link
Owner

Fixes #585

Changes proposed in this pull request:

  • Check for references before deleting accounts in currency, categories and products

Others currently cannot be removed from the UI, but should also be fixed with time.

@VMelnalksnis VMelnalksnis added type:bug Something isn't working area:api labels Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #859 (d2e0c10) into master (9cd79a8) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #859      +/-   ##
==========================================
+ Coverage   73.49%   73.53%   +0.04%     
==========================================
  Files         412      412              
  Lines       11292    11306      +14     
==========================================
+ Hits         8299     8314      +15     
+ Misses       2993     2992       -1     
Components Coverage Δ
API 78.82% <100.00%> (+0.05%) ⬆️
UI 59.89% <ø> (ø)

@VMelnalksnis VMelnalksnis merged commit d2e0c10 into master Jun 23, 2023
12 checks passed
@VMelnalksnis VMelnalksnis deleted the delete-fix branch June 23, 2023 15:36
@VMelnalksnis VMelnalksnis temporarily deployed to github-pages June 23, 2023 15:36 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can remove currency from account when there are transactions using it
1 participant