Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registration using GitHub #940

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Fix registration using GitHub #940

merged 1 commit into from
Sep 3, 2023

Conversation

VMelnalksnis
Copy link
Owner

Changes proposed in this pull request:

  • Use the provider key as the user id if it is a GUID, otherwise create a new one

This fix is needed because GitHub provider key is an int.

@VMelnalksnis VMelnalksnis added type:bug Something isn't working area:api labels Sep 3, 2023
@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Merging #940 (3f41e35) into master (1d43bcd) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #940      +/-   ##
==========================================
- Coverage   72.97%   72.97%   -0.01%     
==========================================
  Files         427      427              
  Lines       11602    11604       +2     
==========================================
+ Hits         8467     8468       +1     
- Misses       3135     3136       +1     
Components Coverage Δ
API 78.79% <66.66%> (-0.01%) ⬇️
UI 59.13% <ø> (ø)

@VMelnalksnis VMelnalksnis merged commit 3f41e35 into master Sep 3, 2023
10 of 12 checks passed
@VMelnalksnis VMelnalksnis deleted the fix-github-auth branch September 3, 2023 07:55
@VMelnalksnis VMelnalksnis temporarily deployed to github-pages September 3, 2023 07:55 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant