Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create channel feature #94

Merged
merged 54 commits into from
Jun 11, 2024
Merged

Create channel feature #94

merged 54 commits into from
Jun 11, 2024

Conversation

VMironiuk
Copy link
Owner

No description provided.

@VMironiuk
Add create a channel feature spec
3838bcf
@VMironiuk
Prepare ChannelsServiceTests to further distinguish between load() an…
4cf1c32 
…d create() methods tesing
@VMironiuk
ChannelsService.create sends create request by URL
591ba4e
@VMironiuk
Rename ChannelsService.load method to ChannelsService.loadChannels
daa2a5b
@VMironiuk
Rename ChannelsService.create method to ChannelsService.createChannel
2de80ee
@VMironiuk
Add ChannelsServiceConfiguration
eadc685
@VMironiuk
Fix ChannelsService composition at the app level
748944d
@VMironiuk
Fix BeChattediOS dependencies
27f4e43
@VMironiuk
Fix ChannelsSericeTest.test_create_sendsCreateRequestByURL (both name…
3f91102 
… and logic)
@VMironiuk
ChannelsService.createChannel send request twice
eb80337
@VMironiuk
ChannelsService.createChannel sends HTTP request as POST method
a8c9e98
@VMironiuk
ChannelsService.createChannel sends request as application/json conte…
b14b011 
…nt type
@VMironiuk
ChannelsService.createChannel sends request with auth token
187d955
@VMironiuk
Introduce CreateChannelPayload
a05fdd8
@VMironiuk
ChannelsService.createChannel sends CreateChannelPayload
82ab880
@VMironiuk
ChannelsService.createChannel delivers success on 200 HTTP response
2818029
@VMironiuk
ChannelsService.createChannel delivers server error on 500 HTTP response
b9c45ba
@VMironiuk
Shorter enum cases writing
58fd3bf
@VMironiuk
ChannelsService.createChannel does not deliver result after SUT insta…
a96400d 
…nce has been deallocated
@VMironiuk
Bump OS versions
9595776
@VMironiuk
ChannelsViewModel.createChannel sends loadChannels request on success
0089db7
@VMironiuk
Rename ChannelsViewModelTests.test_load_... to ChannelsViewModeTests.…
7ea1a5a 
…test_loadChannels_...
@VMironiuk
ChannelsViewMode.createChannel does not send loadChannels request whe…
f559cc3 
…n fails
@VMironiuk
Rename ChannelsServiceProtocol.LoadChannelsError tp ChannelsServicePr…
749067e 
…otocol.ChannelsServiceError
@VMironiuk
Add missing ChannelsLoadingError.conectivity handler
1b5ad07
@VMironiuk
Rename ChannelsServiceProtocol.load to ChannelsServiceProtocol.loadCh…
67484fa 
…annels
@VMironiuk
Move ChannelItem conformance to Equatable to a separate file in Helpe…
cf66029 
…rs group
@VMironiuk
Add ChannelsViewModelTests.makeSUT helper factory method
27b97e8
@VMironiuk
Split channel creation service from channels loading service
7424738
@VMironiuk
Rename ChannelsService to ChannelsLoadingService
7d11710
@VMironiuk
Update to recommended settings
7e9857a
@VMironiuk
Remove .invalidData case from ChannelCreationError
957dbd5
@VMironiuk
CreateChannelViewModel.init does not send createChannel request
799b073
@VMironiuk
CreateChannelViewModel.createChannel sends createChannel request
ddd97fc
@VMironiuk
CreateChannelViewModel.createChannel sends two createChannel requests…
4c1b7e6 
… when called twice
@VMironiuk
CreateChannelViewModel.createChannel delivers success on successful r…
5db370f 
…esponse
@VMironiuk
CreateChannelViewModel.createChannel delivers server error when reque…
0479bde 
…st fails with server error
@VMironiuk
CreateChannelViewModel.createChannel delivers connectivity error when…
c45373e 
… create channel request fails with connectivity error
@VMironiuk
CreateChannelViewModel.createChannel delivers unknown error when crea…
f63089e 
…te channel fails with unknown error
@VMironiuk
Remove duplicated code
bacd7cd
@VMironiuk
Check CreateChannelViewModel's state transitions for happy path
f489138
@VMironiuk
Check CreateChannelViewModel's state transitions for sad path
7e7f907
@VMironiuk
Move common UI elements to one level up in the project hierarcht
da18219
@VMironiuk
Give button styles more general names
fc038f3
@VMironiuk
Implement basic UI for the CreateChannelView
85ba3a7
@VMironiuk
Integrate CreateChannelFeature
7b6e752
@VMironiuk
Animate create channel state transitions
2017303
@VMironiuk
Add Extensions group to the BeChatted project
398b77b
@VMironiuk
Move animation performing from create channel view model to a separat…
e2758c1 
…e type
@VMironiuk
Clear channel name and description in case of successful channel crea…
3f7ba95 
…tion
@VMironiuk
Hide keyboard after the create channel button tapped action
cdbb3dd
@VMironiuk
Show success view when new channel was created
9b9d9f3
@VMironiuk
Add vibration in case of successful channel creation
20b7ea6
@VMironiuk
Refactor vibration after successful channel creation
8c6bbcf
@VMironiuk VMironiuk linked an issue Jun 11, 2024 that may be closed by this pull request
Create channel feature #93
Closed
9 tasks
@VMironiuk VMironiuk merged commit 01a2236 into dev Jun 11, 2024
1 check passed
@VMironiuk VMironiuk deleted the create-channel-feature branch June 11, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create channel feature
1 participant
@VMironiuk