Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change: bug fix
What
Fix the issue that problems are not properly copied to the destination contest when executing a contest cloning.
Why
The assignment of
pk
toNone
affects QuerySets that haven't been evaluated yet (not sure if these behaviors are intended). Usinglist()
effectively forces the queries to perform actual db hits (link).https://docs.djangoproject.com/en/4.2/topics/db/queries/#querysets-are-lazy
The performance impact of these changes is negligible for all practical use cases.
How Has This Been Tested?
Tested on local.
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.By submitting this pull request, I confirm that my contribution is made under the terms of the AGPL-3.0 License.