Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update org URL scheme from <id-slug> to <slug> #334

Merged
merged 3 commits into from Sep 28, 2023

Conversation

magnified103
Copy link
Contributor

@magnified103 magnified103 commented Sep 26, 2023

Description

Type of change: new feature

What

Update organization URL scheme from organization/<id-slug> to organization/<slug> and redirect old URLs to the corresponding new one.

Add validation rule to ensure organization slugs begin with a-zA-Z.

Why

Slugs have been unique since #332, so there's no need to append the ids as in the old format.

How Has This Been Tested?

Tested on local.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have explained the purpose of this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the README/documentation
  • Any dependent changes have been merged and published in downstream modules
  • Informed of breaking changes, testing and migrations (if applicable).
  • Attached screenshots (if applicable).

By submitting this pull request, I confirm that my contribution is made under the terms of the AGPL-3.0 License.

@magnified103 magnified103 force-pushed the org-use-slug-url branch 2 times, most recently from d152f94 to e0f29b7 Compare September 26, 2023 08:46
@magnified103 magnified103 marked this pull request as draft September 26, 2023 10:50
@magnified103 magnified103 marked this pull request as ready for review September 26, 2023 16:42
@magnified103 magnified103 marked this pull request as draft September 26, 2023 16:43
Create a validation rule to ensure slugs begin with a letter
@magnified103 magnified103 marked this pull request as ready for review September 26, 2023 16:53
@hieplpvip
Copy link
Contributor

You missed a few URLs but otherwise good work! LGTM

@hieplpvip hieplpvip merged commit 40192be into VNOI-Admin:master Sep 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants