OrtLoggingLevel → tracing::Levelの割り当てを変更
#16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
Jan 26, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrtLoggingLevel→tracing::Levelへの割り当てを変更します。onnxruntime-rsでは、5種類→5種類で一対一で対応させたかったのはわかるのですが、ORT本体の"INFO"が"DEBUG"に、"WARNING"が"INFO"に、"ERROR"が"WARN"になって表示されるようになっている状態です。
このPRではそれらの対応を一段階引き上げます。
欠点としてユーザーが見る、COREの起動時に出るORTの諸々のメッセージのレベルが
INFOからWARNに変わります。ただ元々WARNINGだったのでよいのではとも思います。