singing.tsのsearchPhrasesをリファクタリング #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
weweweok
changed the title
|
動作確認してみました。 oss.mp4 |
weweweok
commented
Feb 22, 2024
| @@ -855,9 +855,11 @@ export const singingStore = createPartialStore<SingingStoreTypes>({ | |||
| phraseNotes.push(note); | |||
|
|
|||
| const currentNoteEnd = note.position + note.duration; | |||
| const nextNoteStart = notes[noteIndex + 1].position; | |||
| const nextNoteStart = | |||
| noteIndex + 1 < notes.length ? notes[noteIndex + 1].position : null; | |||
| if ( | |||
| noteIndex === notes.length - 1 || | |||
There was a problem hiding this comment.
if( noteIndex === notes.length - 1 ||
note.position + note.duration !== notes[noteIndex + 1].position)↑このように書くと、notes[noteIndex + 1]が存在しない場合も、条件が通るので、nextNoteStart == nullと明示する形にしました。
|
レビューを参考に具体例をちょっと書いてみました。 |
Hiroshiba
approved these changes
Mar 18, 2024
Hiroshiba
reviewed
Mar 18, 2024
Hiroshiba
reviewed
Mar 18, 2024
| ) { | ||
| const phraseFirstNote = phraseNotes[0]; | ||
| const phraseLastNote = phraseNotes[phraseNotes.length - 1]; | ||
| const hash = await generatePhraseHash({ | ||
| const params = { |
There was a problem hiding this comment.
「generate params」だとパラメータを作るという意味になってしまうので、単純にparamsにしてみました！
|
マージします！ またよければリファクタリングに挑戦してみてください！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
題の通りです。
singing.tsのRENDERが結構複雑みたいなので、小出しでリファクタリングできればと思っています。
関連issue