feat: 書き出し先を固定を有効にしたときに書き出し先が未選択の場合は自動的にダイアログを表示する #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabonerune
force-pushed
the
fix/static-save-dir
branch
from
6cbc2d6
to
66590e0
Compare
Hiroshiba
reviewed
Feb 28, 2024
Hiroshiba
approved these changes
Mar 11, 2024
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
Hiroshiba
reviewed
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
書き出し先を固定を有効にしたときに書き出し先が未選択の場合、自動的にダイアログを表示するようにします。
これにより意図せずインストールディレクトリにファイルが保存されてしまう問題を回避します。
関連 Issue
その他
既に書き出し先を固定・未選択の場合起動直後に突然ダイアログが表示されてしまうのでとりあえずマイグレーション処理で書き出し先の固定を無効に切り替えるようにしてしまいました。