ソング：レンダリング順を改善 #1909
Merged
ソング：レンダリング順を改善 #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 音高補正にしつつ開発時のみ機能に * VoiceKey→GuidePitch * とりあえず実装としては完成 * keyRangeAdjustmentに * (note|guide)KeyShiftを消し、補正→調整にする * keyShiftを全てKeyRangeAdjustmentへ
Hiroshiba
reviewed
Mar 6, 2024
|
多分直ったはず？ |
Hiroshiba
reviewed
Mar 7, 2024
src/sing/domain.ts
Outdated
|
|
||
| /** | ||
| * 次にレンダリングするべきPhraseを探す。 | ||
| * 存在しない場合は[undefined, undefined]を返す。 |
There was a problem hiding this comment.
まーーー変数定義が必要にはなりますが、たぶんundefinedを返す実装のがスマートですかねぇ。
将来値増やそうとした時とかに壊れていきそうですし。
There was a problem hiding this comment.
エラーを投げるようにしました（どちらでもよさそう）
Co-Authored-By: Hiroshiba <Hiroshiba@users.noreply.github.com>
sigprogramming
approved these changes
Mar 7, 2024
Co-Authored-By: sigprogramming <sigprogramming@users.noreply.github.com>
Hiroshiba
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
ソングエディタのレンダリング順を良い感じにします。
関連 Issue
スクリーンショット・動画など
sozai.vvproj.-.VOICEVOX.-.Ver.999.999.999.ubuntu.2024-03-06.19-41-38.mp4
その他
実際の優先順はdoc commentをみてもらえれば