ノートをドラッグ移動する処理の際に上下への境界チェック処理を入れる #1975
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madosuki
changed the title
VOICEVOX.-.Ver.999.999.999.-.Google.Chrome.2024-04-04.15-00-58.mp4ちょっと試してましたが、これでも限界突破できそうですね... |
|
なるほど矩形選択モードを失念しておりました． |
Hiroshiba
reviewed
Apr 26, 2024
sevenc-nanashi
pushed a commit
to sevenc-nanashi/voicevox
that referenced
this pull request
Apr 28, 2024
* add check to boundary of score * delete line * change a value referenced to check boundary * fix overlook case of select rect mode * Apply suggestions from code review --------- Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
cursorNoteNumberをチェックして境界を越えないようにします．
関連 Issue
close #1959
スクリーンショット・動画など
その他