Add: 0.19のマイグレーションを追加 #2016
Merged
Add: 0.19のマイグレーションを追加 #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Apr 26, 2024
src/backend/common/ConfigManager.ts
Outdated
Comment on lines
142
to
149
| (config) => { | ||
| if ( | ||
| Object.prototype.hasOwnProperty.call(config, "showPitchInSongEditor") | ||
| ) { | ||
| config.enablePitchEditInSongEditor = config.showPitchInSongEditor; | ||
| delete config.showPitchInSongEditor; | ||
| } | ||
| }, |
There was a problem hiding this comment.
試してみたらうまくいかなかった･･･！ 多分experimentalSetting内ですね！
Hiroshiba
reviewed
Apr 26, 2024
src/store/project.ts
Outdated
Comment on lines
452
to
455
| // pitchEditDataの追加 | ||
| for (const track of projectData.song.tracks) { | ||
| track.pitchEditData = []; | ||
| } |
Hiroshiba
reviewed
Apr 26, 2024
|
LGTM！！！ ありがとうございました！ |
sevenc-nanashi
added a commit
to sevenc-nanashi/voicevox
that referenced
this pull request
Apr 28, 2024
* Add: 0.19のマイグレーションを追加 * Fix: showPitchInSongEditorがあるときだけdeleteするようにする * バグ修正とコメント変更 * typescriptのバージョンが古くてエラーになった --------- Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
コンフィグのshowPitchInSongEditor -> enablePitchEditInSongEditor、
トラックのpitchEditDataの追加をマイグレーションするコードを追加します。
関連 Issue
スクリーンショット・動画など
（なし）
その他
（なし）