Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

labeler.ymlにenable-versioned-regexを追加 #584

Merged
merged 1 commit into from
Dec 13, 2021
Merged

labeler.ymlにenable-versioned-regexを追加 #584

merged 1 commit into from
Dec 13, 2021

Conversation

eggplants
Copy link
Contributor

内容

必須パラメータのenable-versioned-regexが抜けていたので追加

関連 Issue

#580

その他

https://github.com/VOICEVOX/voicevox/actions/runs/1571876696

aoirint
aoirint approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@aoirint aoirint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

Issue Template内のコメントにバージョン情報を記述して、ラベリング処理のバージョン管理ができるようにする機能の有効化フラグみたいですね（1で有効化）。

@eggplants
Copy link
Contributor Author

Issue作成時しかトリガーを置いてないので0でいいかなと思いました。

Hiroshiba
Hiroshiba approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@Hiroshiba Hiroshiba merged commit d614f76 into VOICEVOX:main Dec 13, 2021
@eggplants eggplants deleted the fix_labeler branch December 13, 2021 20:02
@qryxip qryxip mentioned this pull request Jan 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

@aoirint aoirint aoirint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eggplants @Hiroshiba @aoirint