Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.ymlの修正 #591

Merged
merged 4 commits into from
Dec 14, 2021
Merged

build.ymlの修正 #591

merged 4 commits into from
Dec 14, 2021

Conversation

eggplants
Copy link
Contributor

@eggplants eggplants commented Dec 13, 2021

内容

build.ymlvoicevox_resourceのリサイズに合わせて修正しました。
*.png_largepublicから除外されます。
Bashスクリプトの気になった細かいとこも修正しています。

関連 Issue

VOICEVOX/voicevox_resource#2
VOICEVOX/voicevox_resource#4

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

が入るとそもそもリソースvoicevox_resourceから取ってこなくなるかもですが、次アプデまでにどうなるかも未定なのでマージすする方向で良いと感じました。

.github/workflows/build.yml Show resolved Hide resolved
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

私が分からないながら手探りで書いた部分もきれいに修正されていて、ありがたいです...!

@eggplants
Copy link
Contributor Author

eggplants commented Dec 14, 2021

$ echo -e "test\ntest">a
$ str_config="$(cat a)"
$ echo "${str_config//$'\n'/\\n}"
test\ntest

@Hiroshiba Hiroshiba merged commit 45629a1 into VOICEVOX:main Dec 14, 2021
@eggplants eggplants deleted the fix_ci branch December 14, 2021 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants