お問い合わせ画面の増設（#615） #620
Merged
お問い合わせ画面の増設（#615） #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
お問い合わせ画面を作成(#615）
Hiroshiba
requested changes
Dec 27, 2021
src/store/index.ts
Outdated
| @@ -85,6 +85,9 @@ export const indexStore: VoiceVoxStoreOptions< | |||
| async GET_PRIVACY_POLICY_TEXT() { | |||
| return await window.electron.getPrivacyPolicyText(); | |||
| }, | |||
| async GET_Coninfo_TEXT() { | |||
There was a problem hiding this comment.
基本的に文字のケース（大文字小文字など）は周囲と揃えて頂ければ！
（自由度が下がって議論の手間を省けるので）
ConinfoはCONTACT INFOMATIONの略語でしょうか。
文脈を知らなくても誰にでも意味が通じるよう、GET_CONTACT_TEXTにしておくのはどうでしょう？
There was a problem hiding this comment.
@Hiroshiba
ConinfoはCONTACT INFOMATIONの略語です。
単にテスト書いて入れてるだけなので、後のコミットで修正します。
There was a problem hiding this comment.
テスト用、なるほどです！
githubはプルリクエストが未完成であることを示せるように、draft機能があるのでちょっとdraftにしちゃいますね。
完成したらこちらの方法でdraftを外して頂けると！！
src/type/preload.d.ts
Outdated
| @@ -8,6 +8,7 @@ export interface Sandbox { | |||
| getUpdateInfos(): Promise<UpdateInfo[]>; | |||
| getOssCommunityInfos(): Promise<string>; | |||
| getPrivacyPolicyText(): Promise<string>; | |||
| getConinfo_Text(): Promise<string>; | |||
There was a problem hiding this comment.
同じくケースを揃えちゃって getContactTextだと綺麗そうです
Fixed text shaking. Test push.
|
@Hiroshiba
|
|
お問い合わせは使い方などと同じく、エンジンからではなく組み込みでいいかなと思いました。 |
|
@Hiroshiba ビルド成功しても真っ白なので、どこから読んでるんだろうと思いまして。 （ほぼ、使い方のコピペなんですが。） |
|
それはコードを読んで頂ければ…！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
ディスカッション：使い方の一番下にあるお問い合わせに関して #615 でしているお問い合わせ画面の追加のプルリクです。
関連 Issue
close #615
その他
src/components/ContactInfo.vueのContact.value = md.render(await store.dispatch("GET_Coninfo_TEXT"));がうまくビルド通らなくて悩み中。