Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

保存確認ダイアログの×ボタンをキャンセル扱いにする #663

Merged
merged 2 commits into from
Jan 23, 2022
Merged

保存確認ダイアログの×ボタンをキャンセル扱いにする #663

merged 2 commits into from
Jan 23, 2022

Conversation

Hiroshiba
Copy link
Member

内容

ソフトウェアを閉じようとしたときに出てくる確認ダイアログを閉じると、キャンセルではなく破棄の扱いになります。
これはデフォルトで一番左のボタンをキャンセルボタンだとみなすためです。

キャンセルボタンの番号を指定可能にし、キャンセルされるようにしました。

関連 Issue

close #662

@Hiroshiba Hiroshiba requested a review from y-chan January 23, 2022 18:49
y-chan
y-chan approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

別に不要かなとも思いますが、一点だけ気になったのでコメントしてみました。

src/background.ts Outdated Show resolved Hide resolved
@Hiroshiba Hiroshiba merged commit 09f60bc into main Jan 23, 2022
@Hiroshiba Hiroshiba deleted the 保存確認ダイアログの×ボタンをキャンセル扱いにする branch January 23, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y-chan y-chan y-chan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

保存確認ダイアログの×ボタンの挙動を変更する
2 participants
@Hiroshiba @y-chan