Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Androidでの注意を追加 #682

Merged
merged 2 commits into from Nov 17, 2023
Merged

Add: Androidでの注意を追加 #682

merged 2 commits into from Nov 17, 2023

Conversation

sevenc-nanashi
Copy link
Member

内容

AndroidだとTMPDIR環境変数を用意しないと動かないのを修正します。

関連 Issue

その他

（なし）

qryxip
qryxip approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@qryxip qryxip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Rust/C/Pythonでも「temporary directoryにファイルを置くので一部の環境では問題になることがある。例えばAndroid…」みたいなドキュメントで統一した方がよい気がしないでもないですが、まあ多分良いでしょう。

Hiroshiba
Hiroshiba approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

個人的にはドキュメントというよりexampleとかに書くのがいいのかなと思いました。
（まあandroidのexampleはないのですが）

@Hiroshiba Hiroshiba merged commit 3174372 into VOICEVOX:main Nov 17, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

@qryxip qryxip qryxip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sevenc-nanashi @Hiroshiba @qryxip