Rust 1.77の新機能を導入する #771
Merged
Rust 1.77の新機能を導入する #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenc-nanashi
approved these changes
Apr 2, 2024
Hiroshiba
reviewed
Apr 9, 2024
| @@ -18,7 +18,7 @@ chrono = { version = "0.4.26", default-features = false } | |||
| clap = "4.0.10" | |||
| color-eyre = "0.6.2" | |||
| colorchoice = "1.0.0" | |||
| cstr = "0.2.11" | |||
| cstr = "0.2.11" # https://github.com/dtolnay/syn/issues/1502 | |||
There was a problem hiding this comment.
このコメントが解消される条件をメモっておかないてあげると、他の人も意図がわかって良さげな気がしました！
There was a problem hiding this comment.
多分dtolnay氏か誰かが腰を上げればスムーズに解決しそうなissueなので、長々と文脈を書かないでいいかなと思いました。cstrがどういうライブラリなのかを考えればリンク先のissueのタイトルで大体はわかるようになっていると思います。
There was a problem hiding this comment.
多分dtolnay氏か誰かが腰を上げればスムーズに解決しそうなissue
そう言ってるうちに実装されましたね。あとはクレートとしてのリリースがなされればc"…"への置き換えができるはず。
dtolnay/syn#1622
Hiroshiba
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
Rust 1.77に入った
f32::round_ties_evenと<[_]>::chunk_byを使います。(厳密に言うと後者はもう使われていて、コピーしてきたものはただのdead codeになっているのですが)
cstrも
c"…"に置き換えたかったのですが、残念ながらsynがまだ対応していないためderive macroもcbindgenもまだc"…"を理解しません。そのためcstr!の置き換えは現状一つも不可能なので、コメントだけ入れています。関連 Issue
Update dependency Rust to v1.77.1 #767Update dependency Rust to v1.77.0 #763
その他