Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

追加: speaker 系 API にドキュメントを追加 #1263

Merged
merged 7 commits into from
May 29, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 18, 2024

内容

概要: speaker 系 API にドキュメントを追加

現在の GET /speakers / GET /singers は API ドキュメントに説明が欠落している。
また GET /speaker_infoGET /singer_info は同一の説明を持っており、違いが表現できていない。

このような背景から、speaker 系 API にドキュメントを追加することを提案します。

関連 Issue

ドキュメント内での語彙に関する issue: #1262

@tarepan tarepan requested a review from a team as a code owner May 18, 2024 08:01
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 18, 2024 08:01
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あっすみません!
speaker/singerはコード内での表記で、ドキュメントでのドメイン用語は別の形かと考えていました 🙇

#1262 (comment) にて相談コメントをさせていただきました 🙇

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

たしかにここのドキュメントの表記は歌手・話者じゃないとAPIと辻褄合わないですね・・・!!

@Hiroshiba Hiroshiba merged commit 3149a19 into VOICEVOX:master May 29, 2024
4 checks passed
@tarepan tarepan deleted the refactor/speaker_apis branch May 29, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants