Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverageのコメントをアップデートするように修正 #150

Merged
merged 3 commits into from Oct 23, 2021
Merged

coverageのコメントをアップデートするように修正 #150

merged 3 commits into from Oct 23, 2021

Conversation

y-chan
Copy link
Member

@y-chan y-chan commented Oct 23, 2021

内容

Coverageコメントを新たに追加するのではなく、すでにある場合はそれを更新するようにしました。

関連 Issue

close #148

スクリーンショット・動画など

y-chan#6 (comment)
image
コメントがBot自身によって更新されていることがわかります。

@github-actions
Copy link

Coverage Result

Resultを開く
Name Stmts Miss Cover
run.py 200 140 coverage-30%
voicevox_engine/acoustic_feature_extractor.py 81 35 coverage-57%
voicevox_engine/full_context_label.py 145 7 coverage-95%
voicevox_engine/kana_parser.py 75 1 coverage-99%
voicevox_engine/model.py 64 1 coverage-98%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/synthesis_engine.py 121 104 coverage-14%
TOTAL 690 288 coverage-58%

1 similar comment
@github-actions
Copy link

Coverage Result

Resultを開く
Name Stmts Miss Cover
run.py 200 140 coverage-30%
voicevox_engine/acoustic_feature_extractor.py 81 35 coverage-57%
voicevox_engine/full_context_label.py 145 7 coverage-95%
voicevox_engine/kana_parser.py 75 1 coverage-99%
voicevox_engine/model.py 64 1 coverage-98%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/synthesis_engine.py 121 104 coverage-14%
TOTAL 690 288 coverage-58%

Hiroshiba
Hiroshiba approved these changes Oct 23, 2021
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

@Hiroshiba Hiroshiba merged commit a64cc9e into VOICEVOX:master Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coverageコメントの改善
2 participants
@y-chan @Hiroshiba