Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESOURCE内のclean_character_info.pyスクリプトを利用する #664

Conversation

Hiroshiba
Copy link
Member

内容

VOICEVOX RESOURCE内の話者情報周りのデータ構造が変わりました。
clean用のスクリプトを用意することにしたので、それをエンジン側から実行します。

関連 Issue

その他

releaseしたもの

完成物の差分を見てみて、リソース周りに差がないことを確認しました。

set -eux

tag=0.15.0-preview.3
gh release download $tag -R VOICEVOX/voicevox_engine -p voicevox_engine-windows-directml-$tag.7z.001
"C:\Program Files\7-Zip\7z.exe" x -y -o$tag voicevox_engine-windows-directml-$tag.7z.001

tag=0.15.0-check-clean-resource.3
gh release download $tag -R Hiroshiba/voicevox_engine -p voicevox_engine-windows-directml-$tag.7z.001
"C:\Program Files\7-Zip\7z.exe" x -y -o$tag voicevox_engine-windows-directml-$tag.7z.001

diff -r \
    "0.15.0-preview.3" \
    "0.15.0-check-clean-resource.3" \
    >diff.diff

@Hiroshiba Hiroshiba requested a review from a team as a code owner April 15, 2023 14:47
@Hiroshiba Hiroshiba requested review from y-chan and removed request for a team April 15, 2023 14:47
@github-actions
Copy link

github-actions bot commented Apr 15, 2023

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 2 1 coverage-50%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 3 1 coverage-67%
voicevox_engine/dev/synthesis_engine/mock.py 36 2 coverage-94%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/metas/Metas.py 33 0 coverage-100%
voicevox_engine/metas/MetasStore.py 29 14 coverage-52%
voicevox_engine/metas/init.py 2 0 coverage-100%
voicevox_engine/model.py 150 9 coverage-94%
voicevox_engine/mora_list.py 5 0 coverage-100%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetError.py 3 1 coverage-67%
voicevox_engine/preset/PresetManager.py 81 2 coverage-98%
voicevox_engine/preset/init.py 4 0 coverage-100%
voicevox_engine/setting/Setting.py 11 0 coverage-100%
voicevox_engine/setting/SettingLoader.py 19 0 coverage-100%
voicevox_engine/setting/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 201 159 coverage-21%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 57 49 coverage-14%
voicevox_engine/synthesis_engine/synthesis_engine.py 130 11 coverage-92%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 67 9 coverage-87%
voicevox_engine/user_dict.py 144 11 coverage-92%
voicevox_engine/utility/init.py 5 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/core_version_utility.py 9 2 coverage-78%
voicevox_engine/utility/mutex_utility.py 11 1 coverage-91%
voicevox_engine/utility/path_utility.py 26 8 coverage-69%
TOTAL 1413 284 coverage-80%

Copy link
Member

@aoirint aoirint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!
どっちでもいいかなといったコメントを1つだけしてみました!

build_util/process_voicevox_resource.bash Show resolved Hide resolved
@Hiroshiba
Copy link
Member Author

レビューありがとうございます!

このあとはこれに従って 、release-0.14ブランチにcherry-pickしようかなと思います。

@Hiroshiba Hiroshiba merged commit 51625b5 into VOICEVOX:master Apr 17, 2023
@Hiroshiba Hiroshiba deleted the build内でRESOURCE内のclean_character_info.pyスクリプトを利用する branch April 17, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants