Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aurora Cooking Port #8413

Merged
merged 9 commits into from Jul 23, 2020

Conversation

Rykka-Stormheart
Copy link
Contributor

@Rykka-Stormheart Rykka-Stormheart commented Jul 14, 2020

This ports Aurora Cooking, sometimes called Nanako Cooking, from CitRP, who got it from Aurora originally.

Citadel-Station-13/Citadel-Station-13-RP#608
Aurorastation/Aurora.3#1743

Pulled from here with updates to to_chat()

Ovens and fryers now work like the microwave, but also have special trays/baskets that can be inserted and removed with things on them. There's also a crapton of new recipes. Note that you can still use the oven to just bake things, or produce variable food items, to my knowledge. This was specifically kept in when it was originally implemented, IIRC.

  • Cooking now uses several machines to make recipes. Microwave, oven, deep fryer.
  • Recipes have been redone to reflect this.
  • Adds a reagent called Space Spice (used in Synnono's food recipes mostly, prevents recipe conflicts)
  • New foods! Lots of them.
  • You can cook using held mobs. Also, mouse/ratburgers.

Overhauls fryers and ovens to a large degree, cereal/candymaker less so. Refactors all their code, adds a ton of new features

Recipes! All appliances are now compatible with the recipe system, and every recipe has a bitfield of appliances that can make it. They all default to microwave only, and as yet there aren't any that can be made in multiple appliances. But i added several new recipes for the fryer, and redistributed a lot of recipes to fryer and oven. Generally most of those related to baking things (pies, cakes, pizza, etc) now use the oven instead of microwave.

Oven and fryer now need preheating. Takes quite a while and uses realistic amounts of power for commercial machinery. Oven has an openable door and rapidly loses heat when its open.

Fryer now uses an actual vat of oil, which can be topped up from spare cooking oil tanks. The efficiency of the fryer varies based on the remaining quantity of oil. spare tanks are found in maintenance or cargo. Also oiltanks can be asploded to spray oil everywhere, i wrote a new reagents proc to spread the contents of a reagent holder all over the local area, just for this (more plans to use this function in future)

All of cooking is generally redesigned to be less about clicking and more about time management and bulk cooking. Microwave can now make large batches of the same recipe, oven+fryer have 4/5 containers that can each cook many things. In general, cooking is SLOW now, you may need to wait several minutes for your fries. But you can concievably cook 20 batches of fries all at once

Adds a coating mechanic and recipes for batter and beer batter, plus a few fryer recipes that use them. Coatings add reagents to the food for extra nutrition, as well as having masked overlays that give it the appearance of being battered.

Combination cooking is reworked to allow using all the ingredients in a cooking container (such as an oven tray), to fuse them all into one giant cake/pizza/etc. the size of the resulting item varies appropriately based on the quantity of stuff used to make it.

Fixes cooking mobs. A deepfried mouse is now converted into a food item that copies the appearance and simulates reagents. uses some code from devouring that i wrote way back when.

Also adds the mouse burger. We had a sprite for it but it wasnt coded in. thats fixed now. You can stick a fried mouse into a bun

Tweaks several recipes to be a bit more rewarding. Recipe system now has support for producing multiple instances of a result, this is used for several smaller things like cookies and donuts

Basically everything related to cooking is tweaked and fixed up at a low level to make more sense.`

https://user-images.githubusercontent.com/40557659/52112070-10165a80-25cb-11e9-9a72-2c919f0033dd.png (From their PR, may not be accurate).

This is WIP, and will not compile just yet. SHE LIVES!

Bugfixes as of 7/18/20
Microwave not cooking micros/mice: Fixed
Invalid Recipe datum thanks to /microwave prefix: Fixed
Fryer earsplittingly loud: Fixed
Fryer/Oven continuing to cook even after items removed: Fixed
Oven having 'on' icon state when door closed but off: Fixed
Appliances not scaling cooking time/damage based on size: Fixed
Feature added - Burning Food will set off fire alarms and set off a black cloud of smoke!
Overcook time reduced to allow for less margin of error (IE Actively requires you to pay attention)
Multiple Microwave bugfixes, including multicooking/etc not working, recipe errors, icon state errors, ejection errors.

Gif demonstrating new Off/Preheating/Idle Lights
Gif demonstrating micro/mouse cooking in microwave (warning, harsh)
Gif demonstrating new fire alarm system for burning food

This ports Aurora Cooking, sometimes called Nanako Cooking, from CitRP, who got it from Aurora originally. 

Citadel-Station-13/Citadel-Station-13-RP#608

Pulled from here with updates to to_chat()

Ovens and fryers now work like the microwave, but also have special trays/baskets that can be inserted and removed with things on them. There's also a crapton of new recipes. Note that you can still use the oven to just bake things, or produce variable food items, to my knowledge. This was specifically kept in when it was originally implemented, IIRC.

- Cooking now uses several machines to make recipes. Microwave, oven, deep fryer.
- Recipes have been redone to reflect this.
- Adds a reagent called Space Spice (used in Synnono's food recipes mostly, prevents recipe conflicts)
- New foods! Lots of them.
- You can cook using held mobs. Also, mouse/ratburgers.
I can dump the recipes if you'd like.

https://user-images.githubusercontent.com/40557659/52112070-10165a80-25cb-11e9-9a72-2c919f0033dd.png (From their PR, may not be accurate).

This is WIP, and will not compile just yet.
@Azurachi
Copy link

If this adds stuff like the chaos cake please make it not an absolute insanity to create such

@Rykka-Stormheart Rykka-Stormheart marked this pull request as ready for review July 16, 2020 23:55
@Rykka-Stormheart Rykka-Stormheart changed the title WIP Aurora Cooking Port Aurora Cooking Port Jul 16, 2020
@nik707
Copy link

nik707 commented Jul 17, 2020

It's pretty widely enjoyed by the cit community. I'd recommend it.

@Greenjoe12345
Copy link
Contributor

If this adds stuff like the chaos cake please make it not an absolute insanity to create such

the chaos cake is meant to be crazy hard to make i'm pretty sure

Microwave not cooking micros/mice: Fixed
Invalid Recipe datum thanks to /microwave prefix: Fixed
Fryer earsplittingly loud: Fixed
Fryer/Oven continuing to cook even after items removed: Fixed
Oven having 'on' icon state when door closed but off: Fixed
Appliances not scaling cooking time/damage based on size: Fixed
Feature added - Burning Food will set off fire alarms and set off a black cloud of smoke!
Overcook time reduced to allow for less margin of error (IE Actively requires you to pay attention)
Multiple Microwave bugfixes, including multicooking/etc not working, recipe errors, icon state errors, ejection errors.
@Latentish
Copy link
Contributor

The problem with this pr is we don't have it yet. This needs to be merged because cooking has several appliances that are basically only there for show, because literally why wouldn't you use the microwave instead? I tried to port this exact cooking change a couple months ago and failed. I tried to port tg as well but that also didn't work. We need a cooking mechanics update bad, same as a botany mechanics update, but this one is ported and ready.

@Novacat
Copy link
Contributor

Novacat commented Jul 22, 2020

This has a fairly major bug at the moment so until that is fixed this will be flaged as DNM

Cooking times are now no longer 10-15 minutes per item, the LARGEST items will take around ~4-5 minutes, 6 at the maximum in the case of the superbigbite (one of the most filling food items in the game).
Cooking oil tanks added
Appliances are now constructible instead of being eldritch black magic
Recipes are now reorganized to either fryer/oven/grill based on where they're made (Although recipes_microwave still needs a LOT more sorting)
Critical time bug with cooking fixed, AND you can now upgrade your appliances for even higher efficiencies!
@Rykka-Stormheart Rykka-Stormheart force-pushed the shep-dev-aurora-cooking branch 2 times, most recently from 1849cf6 to 886ab72 Compare July 23, 2020 03:24
@Novacat Novacat merged commit 47b3130 into VOREStation:master Jul 23, 2020
@KasparoVy
Copy link
Contributor

KasparoVy commented Jul 23, 2020

Omg it be done

Insane cookery and hopefully wiki updates begins

@Rykka-Stormheart Rykka-Stormheart deleted the shep-dev-aurora-cooking branch July 24, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants