Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAC vendor search is case sensitive #222

Closed
LeSpocky opened this issue Nov 28, 2018 · 3 comments
Closed

MAC vendor search is case sensitive #222

LeSpocky opened this issue Nov 28, 2018 · 3 comments
Labels

Comments

@LeSpocky
Copy link

LeSpocky commented Nov 28, 2018

Please search issues (open and closed) to see the issues has already been reported.
In #145 a hardware address vendor search was added, which I highly appreciate.

Describe the bug
However, as already stated in one of the comments, the search is case sensitive, it only works if you type upper case letters. That breaks user expectations and is cumbersome to type with some keyboards.

I consider that a bug, because lower case letters are perfectly valid for a hexadecimal value.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Menu'
  2. Click on 'Hersteller' (that may be 'Vendor' in English?)
  3. Type a valid address containing lower case letters from a to f
  4. See no results

Expected behavior
00:16:3e is actually the very same (part of) address like 00:16:3E because hexadecimal notation does not differentiate case of letters. So I expect both (and even mixed case) input to get me results.

Screenshots
screenshot_20181206-222819
screenshot_20181206-222914

Note
Some behaviour only occurs on certain devices or versions of Android, please provide the following screenshots/information Device/Android OS (Settings → About Phone) and WiFi Analyzer version (Menu -> About)

screenshot_20181206-222509
screenshot_20181206-222642

Please make hardware address input/search case insensitive!

@VREMSoftwareDevelopment
Copy link
Owner

@LeSpocky

Please fill the missing information in the feature request template we have provided above, this helps us to investigate and resolve this faster.

@LeSpocky
Copy link
Author

LeSpocky commented Dec 6, 2018

@VREMSoftwareDevelopment Although I consider it rude to edit my report without asking, I provided the information in a way you might like better now?!

@VREMSoftwareDevelopment
Copy link
Owner

The fix will be available in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants