Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#392 #407

Closed
wants to merge 7 commits into from
Closed

Conversation

kurahaupo
Copy link
Contributor

@kurahaupo kurahaupo commented Feb 17, 2023

What does this implement/fix? Please describe.
Display the "uptime" in beacons in better human-readable format.

Does this close any currently open issues?
#392

@kurahaupo
Copy link
Contributor Author

fixes #392

@VREMSoftwareDevelopment VREMSoftwareDevelopment changed the base branch from master to feature February 18, 2023 21:43
@kurahaupo kurahaupo force-pushed the fix#392 branch 8 times, most recently from 4ca1ac3 to d7317a5 Compare May 31, 2023 04:23
@kurahaupo
Copy link
Contributor Author

Oh dear, I've just realised this has been sending email for every pushed commit, and triggering the unit tests. Sorry about that.

I'm puzzled as to why JaCoCo now fails, when (as far as I know) I've added test coverage for all of my additions.

@VREMSoftwareDevelopment
Copy link
Owner

Please merge the latest feature branch into fix#392

@VREMSoftwareDevelopment
Copy link
Owner

Please take a look starting at build->coverage-4446

"Rule violated for bundle app: complexity covered ratio is 0.87, but expected minimum is 0.88"

It is not code coverage, it is new added code complexity.

@kurahaupo
Copy link
Contributor Author

I made a specific point of adding tests, so this report is really confusing.

How is "added code complexity" computed?

Is there a penalty for code laid out in a tabular arrangement like "too many statements per line"?

@kurahaupo
Copy link
Contributor Author

kurahaupo commented Jun 11, 2023

I wonder if the coverage tool is getting confused by having two scale measures over the same variable, and thinking they need M+N tests (or even M×N) when in fact the intentional interleaved scales mean that the actual number of tests to have full coverage is significantly fewer, basically max(M,N)+1.

I don't want to wind up with code that's harder to read just to get it to pass a metric.

@VREMSoftwareDevelopment
Copy link
Owner

I don't want to wind up with code that's harder to read just to get it to pass a metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants