chore: update Dockerfile to latest debian, libssl & node 20 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TheGreatRefrigerator
commented
Nov 14, 2023
TheGreatRefrigerator
commented
- fixes issues with libssl encountered when updating to latest vroom-docker
nilsnolde
requested changes
Nov 14, 2023
Dockerfile
Outdated
| @@ -27,15 +27,15 @@ RUN echo "Cloning and installing vroom-express release ${VROOM_EXPRESS_RELEASE}. | |||
| git clone --branch $VROOM_EXPRESS_RELEASE https://github.com/VROOM-Project/vroom-express.git && \ | |||
| cd vroom-express | |||
|
|
|||
| FROM node:12-bullseye-slim as runstage | |||
| FROM node:16.20-bookworm-slim as runstage | |||
There was a problem hiding this comment.
If we're updating, we should update to LTS versions. bookworm is fine, but can we do node 20? 16 is EOL since a few months. (Unless 16.20 mean smth else than I think it does..)
There was a problem hiding this comment.
Yes, should be possible.(Nope i think it's node 16 😬 ) Still have to set up the full stack locally to test this properly. But that's a task for tomorrow :)
There was a problem hiding this comment.
Done. Tested some ors request with node 20 image that worked.
TheGreatRefrigerator
force-pushed
the
master
branch
from
e902137
to
abc276f
Compare
TheGreatRefrigerator
changed the title
- fixes issues with libssl encountered when updating to latest vroom-docker
TheGreatRefrigerator
force-pushed
the
master
branch
from
abc276f
to
3f63487
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.