Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to github docker registry #77

Merged
merged 13 commits into from
Jan 8, 2024
Merged

migrate to github docker registry #77

merged 13 commits into from
Jan 8, 2024

Conversation

nilsnolde
Copy link
Collaborator

@nilsnolde nilsnolde commented Jan 6, 2024

Also:

  • builds latest twice a month and on master pushes, making our own versioning redundant
  • tries out layer caching to accelerate image builds

fixes #68
fixes #72

@nilsnolde
Copy link
Collaborator Author

huh interesting.. didn't think I'd have the permission to push a package to your org @jcoupey , but seems it works fine. probably because it's repo-bound. are you ok with keeping latest on the schedule of 2 weeks? I did add some caching, so if nothing changed in the code base, it should hardly doing anything at all.

@nilsnolde
Copy link
Collaborator Author

@nilsnolde nilsnolde requested a review from jcoupey January 6, 2024 21:37
@jcoupey
Copy link
Contributor

jcoupey commented Jan 8, 2024

builds latest twice a month and on master pushes

If we have a "latest" build on every master push (based on the upstream workflow that is on every PR merge), I don't really see the point of the twice a month thing. Wouldn't it be totally redundant?

@nilsnolde
Copy link
Collaborator Author

If we have a "latest" build on every master push

well, this master, not upstream master. it's not redundant bcs I don't push here often, usually just for releases. so the code would never get updated. I think it's fair, basically mirroring upstream to some degree.

@jcoupey
Copy link
Contributor

jcoupey commented Jan 8, 2024

Right, I did not get it was about pushes to this repo. I'm fine with this setup, especially if you have some caching involved to avoid unnecessary CI stuff.

@nilsnolde nilsnolde merged commit 9311953 into master Jan 8, 2024
1 check passed
@nilsnolde nilsnolde deleted the nn-ghcr branch January 8, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish latest image Ditch Dockerhub for GitHub registry
2 participants