Unclear error with missing executable

[jcoupey]

Whenever the vroom system call can't be performed (e.g. if the executable is not found in PATH), we get a 400 Bad Request and the response is

{"code":2,"error":"Invalid json."}

It should be 500 with a more explicit message.

[jcoupey]

Same when we hit an assert within vroom.

[TimMcCauley]

I have added an internal error in #29 for missing vroom on the PATH which is 127 - https://github.com/VROOM-Project/vroom-express/blob/feature/%2326-code-formatting/src/index.js#L219

ref: http://tldp.org/LDP/abs/html/exitcodes.html

What do you think?

[jcoupey]

The 127 case works when the executable is not found in $PATH.

I just gave a try to a vroom crash due to an assert, and the code is 134 but I don't know how relevant this value is across systems.

Probably the best way to make this more robust is to add a default case in the switch after the 127 one for all other unclear situations? I think this is fine: as long as all error codes from config.vroomErrorCodes are filtered, anything else can be seen as a HTTP_INTERNALERROR_CODE.