Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing skill or step out of reach #946

Closed
mebymyself opened this issue Jul 7, 2023 · 5 comments
Closed

Missing skill or step out of reach #946

mebymyself opened this issue Jul 7, 2023 · 5 comments
Milestone

Comments

@mebymyself
Copy link
Contributor

When response is "Missing skill or step out of reach for vehicle" how to know which job is causing this error?
Is it possible to add a JobId to the error message?

@jcoupey
Copy link
Collaborator

jcoupey commented Jul 8, 2023

That would be useful additional information indeed. It would not be a problem since the error results from a check where we have both vehicle and job ranks at hand:

if (!input.vehicle_ok_with_job(v, job_rank)) {
throw InputException("Missing skill or step out of reach for vehicle " +
std::to_string(vehicle.id) + ".");
}

Happy to review a PR adding this.

@mebymyself
Copy link
Contributor Author

@jcoupey I tried to submit pull request but seems like I am missing permissions.
I have created patch with all changes, Would you apply it, please?

patch.zip

@jcoupey
Copy link
Collaborator

jcoupey commented Jul 13, 2023

Thanks for trying to change this!

By default, you don't have push permission to the repo, so the usual workflow is to push your patch to a branch on your own fork, then create the PR from there.

@mebymyself
Copy link
Contributor Author

@jcoupey Hello, is it possible to give some priority to this issue? The PR is submitted
Thanks

@jcoupey jcoupey added this to the v1.14.0 milestone Jul 20, 2023
@jcoupey
Copy link
Collaborator

jcoupey commented Jul 20, 2023

Done in #952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants