Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RouteSplit fix and refactor #996

Closed
jcoupey opened this issue Sep 21, 2023 · 0 comments · Fixed by #998
Closed

RouteSplit fix and refactor #996

jcoupey opened this issue Sep 21, 2023 · 0 comments · Fixed by #998

Comments

@jcoupey
Copy link
Collaborator

jcoupey commented Sep 21, 2023

While taking a look at #981, I noticed that the recent refactors around sonarcloud reports (see #984 #986) broke the RouteSplit operator altogether. TL;DR an object is moved from then re-used later on.

Fixing this is also a good opportunity to try and improve the current operator logic. Currently we store a std::vector<std::reference_wrapper<RawRoute>> to keep track of the empty routes that may receive parts of the splitted route. This is used down the line in RouteSplit::apply but is totally clumsy and we may as well compute and store only absolute ranks of the vehicles for those routes.

@jcoupey jcoupey added this to the v1.14.0 milestone Sep 21, 2023
jcoupey added a commit that referenced this issue Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant