Fix Order of Operations in Agent.init_oai Method to Ensure Assistant Updates
#127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… locally for proper assistant updates
|
Thanks for bringing this up. I adjusted the logic a bit so only undefined parameters are copied from openai. This means that when initializing your assistant from id you can now only specify parameters that you'd like to check for updates. The rest you can simply set to none, and they will be copied from openai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue in the
Agent.init_oaimethod where the_check_parametersmethod was called after updating the agent's attributes. This caused the parameter check to always returnTrue, preventing the assistant from updating when necessary.Changes Made:
_check_parametersmethod call before updating the agent's attributes.These changes ensure that the assistant's configuration is properly updated when its parameters change, maintaining the correct and up-to-date assistant settings.
close #126