Fix misplaced cursor after VV (#4594)

It should go to the column it started at before visual line mode Fixes #4593
VSCodeVim · Feb 26, 2020 · 11073ad · 11073ad
1 parent 38b49c5
commit 11073ad
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/actions/commands/actions.ts b/src/actions/commands/actions.ts
@@ -2364,6 +2364,12 @@ class CommandExitVisualLineMode extends BaseCommand {
   keys = ['V'];
 
   public async exec(position: Position, vimState: VimState): Promise<VimState> {
+    if (vimState.visualLineStartColumn !== undefined) {
+      vimState.cursorStopPosition = vimState.cursorStopPosition.withColumn(
+        vimState.visualLineStartColumn
+      );
+    }
+
     await vimState.setCurrentMode(Mode.Normal);
 
     return vimState;

diff --git a/test/mode/modeVisualLine.test.ts b/test/mode/modeVisualLine.test.ts
@@ -485,4 +485,11 @@ suite('Mode Visual Line', () => {
     keysPressed: 'Vj<Esc>',
     end: ['rocinante', 'nauvoo', 'anu|bis', 'canterbury'],
   });
+
+  newTest({
+    title: 'Exiting via `VV` returns cursor to original column',
+    start: ['rocinante', 'nau|voo', 'anubis', 'canterbury'],
+    keysPressed: 'VjV',
+    end: ['rocinante', 'nauvoo', 'anu|bis', 'canterbury'],
+  });
 });