Merge pull request #2602 from tyru/v_p-should-update-register

[Fix] p in visual-mode should update register content

src/actions/commands/actions.ts

@@ -1547,11 +1547,18 @@ export class PutCommandVisual extends BaseCommand {
     let oldMode = vimState.currentMode;
     let register = await Register.get(vimState);
     if (register.registerMode === RegisterMode.LineWise) {
+      const replaceRegister = await Register.getByKey(vimState.recordedState.registerName);
       let deleteResult = await new operator.DeleteOperator(this.multicursorIndex).run(
         vimState,
         start,
         end,
-        false
+        true
+      );
+      const deletedRegister = await Register.getByKey(vimState.recordedState.registerName);
+      Register.putByKey(
+        replaceRegister.text,
+        vimState.recordedState.registerName,
+        replaceRegister.registerMode
       );
       // to ensure, that the put command nows this is
       // an linewise register insertion in visual mode of
@@ -1560,6 +1567,11 @@ export class PutCommandVisual extends BaseCommand {
       deleteResult.currentMode = oldMode;
       deleteResult = await new PutCommand().exec(start, deleteResult, true);
       deleteResult.currentMode = resultMode;
+      Register.putByKey(
+        deletedRegister.text,
+        vimState.recordedState.registerName,
+        deletedRegister.registerMode
+      );
       return deleteResult;
     }
 

test/mode/modeVisualLine.test.ts

@@ -316,6 +316,15 @@ suite('Mode Visual Line', () => {
     });
   });
 
+  newTest({
+    title: 'Vp updates register content',
+    start: ['|hello', 'world'],
+    keysPressed: 'ddVpP',
+    // TODO: this is not the same behavior as original Vim.
+    // But currently unnecessary line is left at the end (see #2602).
+    end: ['|world', 'hello', ''],
+  });
+
   suite('replace text in linewise visual-mode with linewise register content', () => {
     newTest({
       title: 'yyVp does not change the content but changes cursor position',