Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-o (go back) record every cursor move ? #2461

Closed
WangRongda opened this issue Mar 20, 2018 · 6 comments · Fixed by #3028
Closed

Ctrl-o (go back) record every cursor move ? #2461

WangRongda opened this issue Mar 20, 2018 · 6 comments · Fixed by #3028

Comments

@WangRongda
Copy link

WangRongda commented Mar 20, 2018

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
FEATURE
What happened:
When I use 'gd' to go defined, it dump to another file, and press ctrl-o to go back.
But go back in vscode is based on step that record every cursor move and the history stack is limited.If I move many time, I could not go back to the last file.
wang2

What did you expect to happen:
Like the native vim: don't record every move or add new feature that support go-back-file-based.
wang

How to reproduce it (as minimally and precisely as possible):

Environment:

  • Extension (VsCodeVim) version:0.11.2
  • VSCode version:1.12.1
  • OS version:4.15.9-1-ARCH
@WangRongda WangRongda changed the title Can ctrl-o based on file instead of step based Can ctrl-o based on file instead of step based? Mar 20, 2018
@WangRongda WangRongda changed the title Can ctrl-o based on file instead of step based? Can ctrl-o go back file based instead of step based? Mar 20, 2018
@akirchhoff-modular
Copy link

Vim does record certain movements within a file as well, but not nearly so many as VSCodeVim erroneously does. The complete list of movements that cause an entry in the jump list consulted by CTRL-O is available in Vim's help, under jump-motions.

@WangRongda WangRongda changed the title Can ctrl-o go back file based instead of step based? Ctrl-o (go back) record every cursor move ? Mar 21, 2018
@WangRongda
Copy link
Author

@alex-xnor
You are right!
I don't know how vim define a jumping, but It should not be a cursor move.

@jazmit
Copy link

jazmit commented Aug 15, 2018

+1 This is really annoying

@shawnaxsom
Copy link
Contributor

Duplicate of #1933? I'm working on a potential solution. I'm tracking positions for any actions that occur within VSCodeVim, and then I'll look at also tracking some major external events like changing the editor or group. I'll then probably need to add a metadata tag on actions to specify whether they should be included in the jump list or not.

@akirchhoff-modular
Copy link

@axs221 Yes, I think this is a duplicate of #1933.

@jpoon
Copy link
Member

jpoon commented Aug 27, 2018

Indeed it as a duplicate and closing it as such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants