Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCodeVim airline affecting color scheme #2948

Closed
haveanicedavid opened this issue Aug 9, 2018 · 4 comments
Closed

VSCodeVim airline affecting color scheme #2948

haveanicedavid opened this issue Aug 9, 2018 · 4 comments

Comments

@haveanicedavid
Copy link

Describe the bug
Airline color changes to the lower information bar happen regardless of configuration settings. "vim.statusBarColorControl": false, just locks the 'normal mode' color.

This prevents information from being shown on certain themes (my screenshot is of the Material theme)

Expected behavior
Color scheme should be unaffected if airline setting is disabled

Screenshots
screenshot 2018-08-09 14 36 17

@jpoon
Copy link
Member

jpoon commented Aug 13, 2018

Can you share your configuration?

@haveanicedavid
Copy link
Author

I just realized that something must have edited my config. The following was added under workbench.colorCustomizations:

    "statusBar.background": "#005f5f",
    "statusBar.noFolderBackground": "#005f5f",
    "statusBar.debuggingBackground": "#005f5f"

Removing them from my config fixed the issue. Closing, thanks!

@Kynolin
Copy link

Kynolin commented Aug 22, 2018

There's a warning about this feature in the main readme about how it functions and the resulting performance impact.

⚠️Experimental feature. Due to VSCode API limitations, this function modifies settings.json in the workspace resulting in latency and a constant changing diff in your working directory (see issue #2124).

If you enable vim.statusBarColorControl and save your settings file, you can observe the status bar color settings being added and altered as you switch between normal/insert/visual. When you disable vim.statusBarColorControl, the configuration lines do not get removed automatically which results in the unexpected status bar colors you experienced. I went through the same thing when I disabled this feature after trying it out myself.

@jpoon
Copy link
Member

jpoon commented Aug 22, 2018

That is correct, we override vscode's statusbar configs as you switch modes to change the color of the status bar. We currently are not deleting those configurations as it's hard for us (the extension) to determine whether those were configurations that the extension configured vs. settings that the user supplied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants