Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

% doesn't ignore unmatched > #3807

Closed
J-Fields opened this issue Jun 2, 2019 · 1 comment · Fixed by #3913
Closed

% doesn't ignore unmatched > #3807

J-Fields opened this issue Jun 2, 2019 · 1 comment · Fixed by #3913
Labels
kind/bug

Comments

@J-Fields
Copy link
Member

J-Fields commented Jun 2, 2019

Describe the bug
% should ignore any characters such as ) or > that are unmatched. It doesn't, so it'll sometimes get stuck.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the start of this line:
    object->method(param1, param2);
  2. Hit %
  3. Notice that nothing happens

Expected behavior
The cursor should jump to ). This doesn't happen because it's trying to find the < that matches with the > on the arrow and doesn't continue when it fails.

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.8.1
  • VSCode version: 1.34.0
  • OS: Windows 10
@J-Fields
Copy link
Member Author

I was wrong about the cause of this. It isn't trying to match the < because matchesWithPercentageMotion is false. It doesn't, however, keep going after realizing this.

@J-Fields J-Fields mentioned this issue Jul 24, 2019
Merged
jpoon pushed a commit that referenced this issue Jul 24, 2019
@J-Fields @jpoon
Make % skip over characters such as '>' (#3913)
5293a37 
These have matches, but are not compatible with the `%` motion (matchesWithPercentageMotion=false). We should skip over them to find one that is compatible.
Fixes #3807
@jpoon jpoon added the kind/bug label Jul 24, 2019
stevenguh pushed a commit to stevenguh/Vim that referenced this issue Aug 27, 2019
@J-Fields @stevenguh
Make % skip over characters such as '>' (VSCodeVim#3913)
804e887 
These have matches, but are not compatible with the `%` motion (matchesWithPercentageMotion=false). We should skip over them to find one that is compatible.
Fixes VSCodeVim#3807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make % skip over characters such as '>'
2 participants
@jpoon @J-Fields