Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ignorecase for sort command #3939

Closed
noslaver opened this issue Aug 2, 2019 · 1 comment · Fixed by #3938
Closed

Support ignorecase for sort command #3939

noslaver opened this issue Aug 2, 2019 · 1 comment · Fixed by #3938
Labels
area/commandline kind/enhancement

Comments

@noslaver
Copy link
Contributor

noslaver commented Aug 2, 2019

Adding the [i] option for the sort command would be nice, i.e.
sort i
and
sort! i

Pull request opened #3938
@noslaver noslaver mentioned this issue Aug 2, 2019
Merged
J-Fields pushed a commit that referenced this issue Aug 27, 2019
@noslaver @J-Fields
Added option to ignore case when sorting (#3938)
05683aa 
Adds [i] option to sort command, which ignores case.
Fixes #3939
@noslaver
Copy link
Contributor Author

noslaver commented Aug 31, 2019 •
edited

Seems like my solution was not correct, localeCompare always ignores case. I'll open a PR with a fix.
Edit: opened #4023

@noslaver noslaver mentioned this issue Aug 31, 2019
Merged
J-Fields pushed a commit that referenced this issue Sep 1, 2019
@noslaver @J-Fields
Fix case sensitive sorting (#4023)
c246ac6 
Fixes #3939
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/commandline kind/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added option to ignore case when sorting
2 participants
@J-Fields @noslaver