Breaks VSCode's Breadcrumbs filtering abilities

[lmartins]

Describe the bug
With VSCode Vim disabled, you can invoke the breadcrumbs dropdown and start typing to quickly navigate through the list of symbols on the current document.

This extension seems to conflict with that, as when you type inside the breadcrumbs dropdown nothing happens.

To Reproduce

1. Run "Focus Breadcrumbs" command.
2. Start typing

Expected behavior
You should see your input on the top right of the breadcrumbs dropdown, and the corresponding matches being highlighted.

[J-Fields]

Likely we're eating that input and need to change a when clause to take into account breadcrumbsActive and/or breadcrumbsVisible.

[jhechtf]

Bump -- still seeing this as of the 1.11.3 release. If it would be helpful I could look into where this change would need to take place? I enjoy the extension but I use breadcrumbs enough that this is really frustrating.

[gerroon]

Any way to get this disabled during breadcrumbs is open?

[Jimmydalecleveland]

I believe you can type / to start searching like you do in the sidebar with the VIM extension. Or am I misunderstanding?

[gerroon]

I will try the suggestion.

[TomeASilva]

I believe you can type / to start searching like you do in the sidebar with the VIM extension. Or am I misunderstanding?

It does not work....

[TomeASilva]

Any updates on this ?

[kumar303]

I believe you can type / to start searching like you do in the sidebar with the VIM extension.

This workaround did it for me in VSCode 1.45.1 and Vim 1.14.5. Thanks.

[TomeASilva]

On Vscode 1.46.1 and vscodevim v1.14.5 is still not working for me, I wonder if is something else about my system that is causing this issue.

[TomeASilva]

I found a workarround, I'm in Vscode version : 1.47.3. When you do "open folder" with Vscode I can't filter the breadcrumbs. If instead I open a new VScode window and transfer one the files to it I can start filtering the breadcrumbs on that window, in the old window the problem persists.

[TomeASilva]

I figured out by trying other versions of the the extension that the problem started in version 1.0.6.

[TomeASilva]

I found the problem: await g.VsCodeContext.Set("listAutomaticKeyboardNavigation",!1) this disables the automatic filtering both on breadcrumbs and on file explorer. I don't know what is the impact for other functionalities of the extension, but i changed this locally and now it is working, by setting it to 1.

[rickstaa]

I experience the same problem when using the Vim extension with the debug variable filter feature. See here the original issue I posted on the vscode github.

[isidorn]

So this is true for all vscode trees. Every tree supports a filter. So for Explorer, Git, Debug Console, Debug Variables and many more...

[rickstaa]

@J-Fields Do you maybe have an update on this issue? I temporary disabled the plugin becuase of this bug. Thanks a lot in advance.

[TomeASilva]

@rickstaa If you really like the extension and you can't live without this feature you can find the extension file in
C:\Users"your_user_name".vscode\extensions\vscodevim.vim-1.18.5\out and on the file extension.js change this parameter : await g.VsCodeContext.Set("listAutomaticKeyboardNavigation",!1) to 1 instead of !1. You should disable automatic updates on the extensions, otherwise when it updates you have to repeat the procedure.

[rickstaa]

@TomeASilva Ah I see reverting back to using the 1.0.5 version. Thanks for the tip I might need that in the future. I currently use a shortcut to toggle the vim extension on and off. I was looking for an update on the bug fix to see if there was anything I could do to help.

Shortcut
Shortcut was given by @commanderfun on #3001.

{
    "key": "ctrl+alt+v",
    "command": "toggleVim",
    "when": "editorFocus"
},

[J-Fields]

@rickstaa Hitting / first allows you to search, is that insufficient for your needs?

[rickstaa]

@J-Fields Thanks a lot for your reply. Although that is a very helpful feature, it does not allow me to use the debug variable filter feature (see this issue). I noticed that toggling the tmux extension also doesn't work anymore on a newer version. The variable filter feature is now broken as long as the vim extension is enabled.

[rickstaa]

@Jimmydalecleveland and @J-Fields their workaround of hitting / seems to work perfectly now. I think some of my custom shortcuts were conflicting! :) This issue can be closed as / is very much in line with regular vim behaviour. Maybe while adding a quick note in the README.md

[grimgort]

the / key doesn't seem to work for me. I still can't use a filter in vscode menus with this extension.

[TomeASilva]

This only works for US keyboards Layouts, I'm on ISO PT, to press "/" I need to press "shift+ 7" to type "/". For some reason on editor I can filter normally, on breadcrumbs and the file explorer it does not work. I change my keyboard layout on windows to US layout and it started to work . I guess it is because US layout as a key solely for "/", you don't need a key combination. It would be cool if in bread crumbs vim could register key combinations, this would probably solve the issue for the people without US keyboards.