Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Supported Keyboards" and respective IKeyMapper-implementations #432

Closed
AntonAderum opened this issue Jul 12, 2016 · 4 comments
Closed

Comments

@AntonAderum
Copy link
Contributor

AntonAderum commented Jul 12, 2016

The IKeyMapper implementations was needed because vscode could not map non-US keyboard to the extensions keymapping. However this seems to no longer be the case.

I tried it out this morning and when i was running the sv-SE keymapper configuration all the mappings were wrong. (I know this isnt listed as supported in your README, but i was the one who did the sv-SE mapping and it did work before). When I debugged it, it turned out that when I for example pressed ">" it not longer sent "shift+oem_102" to the keymapper, but instead sent the correct character ">".

When i tried running without "vim.keyboardLayout" set, it mapped all my keys correctly, even though I am on a swedish keyboard layout.

So it seems that vscode has been fixed to correctly map keys pressed on the keyboard to the correct key in vscode, thus making the custom IKeyMapper implementation both obselete and plain wrong since they now map things incorrectly. It's also confusing for new users that think that they need to use the Supported Keyboards.

  • VSCode Version: 1.3.0
  • VsCodeVim Version: 0.1.1
  • OS: Windows 10
@AntonAderum AntonAderum changed the title Remove "Supported Keyboards" and respective IKeyMapper-implementation Remove "Supported Keyboards" and respective IKeyMapper-implementations Jul 12, 2016
@johnfn
Copy link
Member

johnfn commented Jul 13, 2016

@jpoon do you know more about this than me?

@jpoon
Copy link
Member

jpoon commented Jul 13, 2016

Ooh, sweet. Going through the VSCode history, it seems like handling of international keyboards was greatly improved in January (microsoft/vscode#713) and they are using this internally to map the international keys: https://github.com/Microsoft/node-native-keymap.

Before we remove all the work we did to support these keyboards, we'll obviously need to do a bit more testing to make sure we don't break anything/anybody.

@AntonAderum
Copy link
Contributor Author

Great. I can at least confirm that it works perfectly on Swedish (QWERTY) keyboard using no custom IKeyMapper-implementation.

@jpoon
Copy link
Member

jpoon commented Jul 14, 2016

I unfortunately don't have an international keyboard to test, but just removed it -- hopefully didn't break anybody.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants