Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multicursor issues on split window #4553

Closed
cvaldev opened this issue Feb 10, 2020 · 0 comments · Fixed by #4569
Closed

Multicursor issues on split window #4553

cvaldev opened this issue Feb 10, 2020 · 0 comments · Fixed by #4569
Labels
area/multicursor kind/bug

Comments

@cvaldev
Copy link
Contributor

cvaldev commented Feb 10, 2020

Describe the bug
It seems the cursors don't correspond to the current window but instead to that document's last state.

To Reproduce
Steps to reproduce the behavior:

  1. Create multiple cursors on a document
  2. Split it
  3. On the new window make it a single cursor
  4. Switch back to the original window and immediately perform a move or change mode
  5. See your multiple cursors disappear

The reverse, originally having a single cursor and then creating multiple cursors, will give you unwanted multiple cursors when you go back to your original single cursor window. This second case also creates an issue where if you insert a character, it will be inserted at invisible cursor positions.

Expected behavior
Same as VSCode where the cursors correspond to the current window.

Environment (please complete the following information):

  • Issue Type: Bug
  • Extension Name: vim
  • Extension Version: 1.12.4
  • OS Version: Linux x64 4.15.0-76-generic
  • VSCode version: 1.42.0
@cvaldev cvaldev mentioned this issue Feb 20, 2020
Merged
J-Fields pushed a commit that referenced this issue Feb 25, 2020
syncCursors() will update all internal cursors (#4569)
8cda7f0 
This change makes it so all vimState cursor positions correctly represent VSCode's rather than only updating the main cursor.

Before this change the extension would update all cursors only after a command was executed which could cause issues when using different number of cursors on a split editor and performing an action immediately after switching windows.

Fixes #4553
@berknam berknam mentioned this issue May 29, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/multicursor kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

syncCursors() will update all internal cursors cvaldev/Vim
2 participants
@J-Fields @cvaldev