Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling & repeating a surround action moves the cursor to the beginning of the line #4699

Closed
max-sixty opened this issue Mar 29, 2020 · 6 comments · Fixed by #4780
Closed
Labels
Milestone

Comments

@max-sixty
Copy link
Contributor

Describe the bug
Cancelling a surround action and then restarting it causes the cursor to go to the beginning of the line.

To Reproduce
Steps to reproduce the behavior:

  1. Ensure vim-surround is enabled
  2. Move the cursor somewhere mid-line
  3. Type y s esc, (as though you were going to type y s w ( and changed your mind)
  4. Type y s and the cursor moves to the beginning of the line

Expected behavior
The behavior in (4) wouldn't be changed by the actions in (3), given (3) ended in an escape
NB: Hitting esc multiple times doesn't change from a single esc

Environment (please complete the following information):

  • Extension Version: 1.13.1
  • OS Version: Darwin x64 19.3.0
  • VSCode version: 1.43.2

Thanks again for such a great tool!

@J-Fields
Copy link
Member

Confirmed. Strange bug; I'll try to track it down before the next release.

@J-Fields J-Fields added this to the v1.14.0 milestone Mar 30, 2020
@max-sixty
Copy link
Contributor Author

Thanks @J-Fields !

BTW you should add a "Sponsor" option, given the amount of work you do solo and how many people use the tool...

@J-Fields
Copy link
Member

I appreciate the sentiment, but frankly the bulk of the work was done before I ever got involved, and if anyone's going to make a donation, their local food pantry or homeless shelter needs the money a lot more right now than I ever could.

@gergelyth
Copy link
Contributor

Fixed in #4780. @J-Fields I hope you don't mind me jumping on this issue, it was easy for me to pinpoint the problem after working on #4778, so I thought I'd just do it.

@J-Fields
Copy link
Member

J-Fields commented May 2, 2020

@gergelyth not at all, it's appreciated!

@max-sixty
Copy link
Contributor Author

Thanks @gergelyth !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants