Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append in Visual Block mode clears text to the left when performed on whitespace #4796

Closed
zolrath opened this issue May 4, 2020 · 0 comments
Closed

Append in Visual Block mode clears text to the left when performed on whitespace #4796

zolrath opened this issue May 4, 2020 · 0 comments
Assignees
@J-Fields
Labels
kind/bug

Comments

@zolrath
Copy link

zolrath commented May 4, 2020 •
edited

Describe the bug
When performing a Visual Block selection via <C-v> to make a single-column selection, any row where the selection contains whitespace has all content to the left of the selection cleared when performing an append via <Shift-A>.

To Reproduce
Steps to reproduce the behavior:

  1. Enter a document
  2. Enter visual block mode <C-v>
  3. Select a single column, multiple rows. Ensure some of the rows contain whitespace at the selection column and text to the left of the selection column.
  4. Press <Shift-A>
  5. The text to the left of the whitespace will be deleted. The cursor will be placed to the left of the column, not the right.

Expected behavior
My multiple cursors would appear to the right of the block selected column.

Screenshots
Multi Cursor Issue

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.14.1
  • VSCode version: 1.44.2
  • OS: Windows 10

Additional context
Reproduction confirmed by bronson in the Slack channel.
In addition to the deleting of text, the cursor appears to the left, not the right of the selected column similar to #4795
@J-Fields J-Fields self-assigned this May 4, 2020
@J-Fields J-Fields mentioned this issue May 4, 2020
Closed
J-Fields added a commit that referenced this issue May 4, 2020
@J-Fields
Fix a few issues with A in visual block mode
a0809b9 
- Adds spaces when line isn't long enough (fixes #4795)
- Don't delete text when selection is on whitespace (fixes #4796)
- Works with multiple cursors
berknam pushed a commit to berknam/Vim that referenced this issue May 5, 2020
@J-Fields @berknam
Fix a few issues with A in visual block mode
ab425d0 
- Adds spaces when line isn't long enough (fixes VSCodeVim#4795)
- Don't delete text when selection is on whitespace (fixes VSCodeVim#4796)
- Works with multiple cursors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@J-Fields J-Fields

Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zolrath @J-Fields