Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1293 #1296

Merged
merged 3 commits into from Feb 15, 2017
Merged

Fix for #1293 #1296

merged 3 commits into from Feb 15, 2017

Conversation

xlaech
Copy link
Contributor

@xlaech xlaech commented Feb 14, 2017

When using C-o in Insert Mode to execute a single Normal Mode command, the cursor will be of by one after the change.

Changing the argument input for the specific action fixes this bug, while not changing the behavior of other code

@xconverge
Copy link
Member

Can you wrap it in an if (position.char === 0) then don't do the getRight, I think that is how vim works

@xconverge
Copy link
Member

Thanks for the PR! @johnfn is travelling currently but should drop in some day in the near future to chat/merge it. Just wanted you to know you weren't being ignored if it is quiet for a bit

@xlaech
Copy link
Contributor Author

xlaech commented Feb 14, 2017

No problem. Thanks for the help. This was quite fun. If i find the time i try to get more into the code base. Since this is my main editor the development of this plugin effects me quite a lot ;)

@xconverge
Copy link
Member

Yea, this was a perfect first one to get your feet wet. Get the build going etc.. The codebase is getting quite complex but I am a big supporter of fixing the offby one issues that still exist and definitely encourage you to fix things that annoy/bother you!

@johnfn johnfn merged commit 8140e4f into VSCodeVim:master Feb 15, 2017
@johnfn
Copy link
Member

johnfn commented Feb 15, 2017

Looks good to me. Congrats on your first PR, @xlaech! Greatly appreciated. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants